You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, it is impossible to mock the message or code on a Trowable. On the one hand, getMessage() and getCode() are final in Exception, on the other, the mock generator ignores constructor arguments if the type being mocked is an interface.
The existing behavior doesn't seem correct because on the one hand, PHP currently allows passing more arguments than the method expects (including class constructors). On the other, if it stops doing so at some point later, it should be a test error, not the PHPUnit's call to ignore the arguments.
1. Got rid of hard-coded exception mocks in favor of PHPUnit-generated ones.
2. Reworked AbstractDriverTest::testConvertsException() to use a data provider to make testing all types of exceptions independent.
3. Updated PHPUnit since the reworked code relies on sebastianbergmann/phpunit#3604 and sebastianbergmann/phpunit#3694.
morozov
added a commit
to morozov/dbal
that referenced
this pull request
May 16, 2019
1. Got rid of hard-coded exception mocks in favor of PHPUnit-generated ones.
2. Reworked AbstractDriverTest::testConvertsException() to use a data provider to make testing all types of exceptions independent.
3. Updated PHPUnit since the reworked code relies on sebastianbergmann/phpunit#3604 and sebastianbergmann/phpunit#3694.
Just curious: in what scenario does stubbing/mocking Throwable or Exception make sense? I have never though about this before the recent patches, much less needed it.
In doctrine/dbal, we have some logic of handling/generalizing driver exceptions based on their properties. We do not mock Throwable or Exception directly but we do mock interface DriverException extends Throwable.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, it is impossible to mock the message or code on a
Trowable. On the one hand,getMessage()andgetCode()arefinalinException, on the other, the mock generator ignores constructor arguments if the type being mocked is an interface.The existing behavior doesn't seem correct because on the one hand, PHP currently allows passing more arguments than the method expects (including class constructors). On the other, if it stops doing so at some point later, it should be a test error, not the PHPUnit's call to ignore the arguments.